[
https://issues.apache.org/jira/browse/OAK-4222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
angela resolved OAK-4222.
-------------------------
Resolution: Fixed
Fix Version/s: 1.5.2
Committed revision 1740339.
Fixed as discussed:
- removing the extra options map
- keeping the options.clear in the various finally clauses.
> Cleanup ExternalLoginModuleTest
> -------------------------------
>
> Key: OAK-4222
> URL: https://issues.apache.org/jira/browse/OAK-4222
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external
> Reporter: angela
> Assignee: angela
> Priority: Minor
> Fix For: 1.5.2
>
> Attachments: OAK-4222.patch
>
>
> While looking at the tests present in oak-auth-external I found the
> {{ExternalLoginModuleTest}} keeping it's own protected {{options}} map hiding
> the {{options}} defined and populated in the setup of the base-class.
> Not sure what this was intended to be used for but the fact that the options
> get cleared in the finally-section of some of the test-cases looks quite
> strange to me.
> [~tripod], I would appreciate if you review the attached patch and let me
> know if you think the proposed cleanup breaks the very intention of your
> test-cases. Thanks a lot.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
