[ 
https://issues.apache.org/jira/browse/OAK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411963#comment-15411963
 ] 

Michael Dürig commented on OAK-4097:
------------------------------------

Thanks for the patch, good catch! I applied it at 
http://svn.apache.org/viewvc?rev=1755514&view=rev

Re. the integration test: I'm a bit concerned about the dependency on timing. 
These are the kind of tests prone to failure on CIs. Could it be done without 
depending on timings? I.e. disable the flush thread and invoke flush manually a 
couple of times?



> Add metric for FileStore journal writes
> ---------------------------------------
>
>                 Key: OAK-4097
>                 URL: https://issues.apache.org/jira/browse/OAK-4097
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Chetan Mehrotra
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>             Fix For: Segment Tar 0.0.10
>
>         Attachments: OAK-4097-01.patch, OAK-4097-02.patch
>
>
> TarMK flush thread should run every 5 secs and flush the current root head to 
> journal.log. It would be good to have a metric to capture the number of runs 
> per minute
> This would help in confirming if flush is working at expected frequency or 
> delay in acquiring locks is causing some delays



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to