[
https://issues.apache.org/jira/browse/OAK-4712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485434#comment-15485434
]
Matt Ryan commented on OAK-4712:
--------------------------------
[~amjain] The latest patch I submitted addresses some of the issues you raised.
Rather than wait until all the issues have been addressed I wanted to get this
out for feedback.
The following changes were applied:
* Use a mocked S3DS in S3DataStoreStatsTest, where possible
* Remove usage of test file
* Remove dependency on S3 data store and associated properties - no S3
configuration required
I wasn't able to simply mock S3DataStore in every test case. Some of the tests
require that I be able to control the backend (for example, checking whether a
sync has completed). For these I am still using a very simple S3DataStore
subclass that allows me to replace the backend with something that makes
testing more meaningful.
I have not yet moved any of the tests into oak-blob-cloud. I'm not sure it
makes much sense to do so. Perhaps I am missing something? The purpose of the
test is to exercise the functionality being added which is mostly in
S3DataStoreStats, which lives in oak-core. Each test creates an
S3DataStoreStats object as the system under test. I tried moving some things
to oak-blob-cloud, but it looked to me that any test I were to move would end
up being so limited in what it could do that it wouldn't really be able to test
much.
I will continue working on the use of MemoryNodeStore instead of the node store
mock, and the addition of more tests like those suggested.
> Publish S3DataStore stats in JMX MBean
> --------------------------------------
>
> Key: OAK-4712
> URL: https://issues.apache.org/jira/browse/OAK-4712
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: blob
> Reporter: Matt Ryan
> Assignee: Amit Jain
> Attachments: OAK-4712.2.diff, OAK-4712.3.diff, OAK-4712.4.diff,
> OAK-4712.5.diff, OAK-4712.7.patch, OAK_4712_6_Amit.patch
>
>
> This feature is to publish statistics about the S3DataStore via a JMX MBean.
> There are two statistics suggested:
> * Indicate the number of files actively being synchronized from the local
> cache into S3
> * Given a path to a local file, indicate whether synchronization of file into
> S3 has completed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
