[
https://issues.apache.org/jira/browse/OAK-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549165#comment-15549165
]
Michael Dürig commented on OAK-4895:
------------------------------------
Patch at
https://github.com/mduerig/jackrabbit-oak/commit/50a6b5f3be72a17121d755f6e04e612a51bea026.
Note, this is on top of the changes I did for OAK-4138.
cc [~frm]
> FileStore cleanup should not leak out file handles
> --------------------------------------------------
>
> Key: OAK-4895
> URL: https://issues.apache.org/jira/browse/OAK-4895
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
> Reporter: Michael Dürig
> Assignee: Michael Dürig
> Labels: technical_debt
> Fix For: Segment Tar 0.0.14
>
>
> {{FileStore.cleanup()}} currently returns a list of {{File}} instances
> relying on the caller to remove those files. This breaks encapsulation as the
> file store is the sole owner of these files and only the file store should be
> removing them.
> I suggest to replace the current cleanup method with one that returns
> {{void}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
