[ 
https://issues.apache.org/jira/browse/OAK-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551258#comment-15551258
 ] 

Francesco Mari commented on OAK-4895:
-------------------------------------

As soon as OAK-4138 is committed, this should immediately follow!

> FileStore cleanup should not leak out file handles
> --------------------------------------------------
>
>                 Key: OAK-4895
>                 URL: https://issues.apache.org/jira/browse/OAK-4895
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>              Labels: technical_debt
>             Fix For: Segment Tar 0.0.14
>
>
> {{FileStore.cleanup()}} currently returns a list of {{File}} instances 
> relying on the caller to remove those files. This breaks encapsulation as the 
> file store is the sole owner of these files and only the file store should be 
> removing them.
> I suggest to replace the current cleanup method with one that returns 
> {{void}}. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to