[
https://issues.apache.org/jira/browse/OAK-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Saurabh updated OAK-5626:
-------------------------------
Attachment: OAK-5626-v2.patch
bq. there are two variants of the warn, one saying blocked, the other
compacted. Maybe that distinction would still be useful?
[~egli], I'm assuming you were referring to {{Revision queue is becoming full.
Further commits will be delayed.}}. For that one, I don't think it would log
too frequently. The issue (at least the way I feel) with blocking case was that
queue length remains capped at max_length when queue is full. Even single
processed event can bring it back to a-bit-empty state. So, it could quite
easily fill up the logs if incoming commit rate was more than processing rate
when queue was full.
Btw, attached [^OAK-5626-v2.patch] which uses virtual clock in test
(Clock.SIMPLE by default) and filters log entries on {{Revision queue is full.
Further revisions will be compacted.}}
> ChangeProcessor doesn't reset 'blocking' flag when items from queue gets
> removed and commit-rate-limiter is null
> ----------------------------------------------------------------------------------------------------------------
>
> Key: OAK-5626
> URL: https://issues.apache.org/jira/browse/OAK-5626
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Vikas Saurabh
> Assignee: Vikas Saurabh
> Priority: Minor
> Attachments: OAK-5626.patch, OAK-5626-v2.patch
>
>
> Following up on conversation at \[0]:
> {{ChangeProcessor#queueSizeChanged}} \[1] sets blocking flag to true if queue
> size is hit (or beyond). The warning "Revision queue is full. Further
> revisions will be compacted." is logged only when it *wasn't* blocking.
> BUT, when queue empties, blocking flag is reset inside if block for
> commitRateLimiter!=null. That means an event chain like:
> # qFull
> # log warn
> # qEmpties
> # qFull
> won't log the WARN after step(4)
> \[0]: http://markmail.org/message/hgein5g3ohyjhw5n
> \[1]:
> https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/observation/ChangeProcessor.java#L307
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
