[
https://issues.apache.org/jira/browse/OAK-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Saurabh updated OAK-5626:
-------------------------------
Attachment: OAK-5626-1.0Branch.patch
I want to backport this to 1.0 branch too. Attaching
[^OAK-5626-1.0Branch.patch] which works on that branch.
The problem is though that in 1.0 branch, we can't configure observation queue
length while utilizing AbstractRepositoryTest class - so, the patch currently
hard-codes observation queue length at 1000. That makes the test run slower (as
compared to original test where obs.q. is set to 5).
I tried to dig which test improvement can we backport to get this in place.
But, there's be multiple ones that needs to be put back. Alternatively, I can
write in only required pieces for this case and be happy about it.
[~mduerig], thoughts on above?
> ChangeProcessor doesn't reset 'blocking' flag when items from queue gets
> removed and commit-rate-limiter is null
> ----------------------------------------------------------------------------------------------------------------
>
> Key: OAK-5626
> URL: https://issues.apache.org/jira/browse/OAK-5626
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Vikas Saurabh
> Assignee: Vikas Saurabh
> Priority: Minor
> Labels: candidate_oak_1_0
> Fix For: 1.2.24, 1.4.14, 1.7.0, 1.8, 1.6.1
>
> Attachments: OAK-5626-1.0Branch.patch, OAK-5626.patch,
> OAK-5626-v2.patch, OAK-5626-v3.patch
>
>
> Following up on conversation at \[0]:
> {{ChangeProcessor#queueSizeChanged}} \[1] sets blocking flag to true if queue
> size is hit (or beyond). The warning "Revision queue is full. Further
> revisions will be compacted." is logged only when it *wasn't* blocking.
> BUT, when queue empties, blocking flag is reset inside if block for
> commitRateLimiter!=null. That means an event chain like:
> # qFull
> # log warn
> # qEmpties
> # qFull
> won't log the WARN after step(4)
> \[0]: http://markmail.org/message/hgein5g3ohyjhw5n
> \[1]:
> https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/observation/ChangeProcessor.java#L307
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
