[ 
https://issues.apache.org/jira/browse/OAK-5740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli updated OAK-5740:
-----------------------------
    Attachment: OAK-5740.v2.patch

Attached [^OAK-5740.v2.patch] which contains a suggested change in 
BackgroundObserver:
* removal off {{full}}
* treating the last queue entry as the overflow/compaction entry
** if an incoming change doesn't fit into the queue, that last entry is replaced

PS: for some reason the diff of {{ObservationQueueFullWarnTest.java}} doesn't 
work for me - {{svn di}} diffs the whole file.. but basically that part is the 
same as previously attached [^OAK-5740.testcase.patch]

[~catholicon], [~mduerig], wdyt?

PS: I'd suggest to anyway only do this in trunk for now and not backport yet 
until we're more confident about this change

> deliver overflow change even without new commit
> -----------------------------------------------
>
>                 Key: OAK-5740
>                 URL: https://issues.apache.org/jira/browse/OAK-5740
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: jcr
>    Affects Versions: 1.6.0
>            Reporter: Stefan Egli
>            Priority: Minor
>         Attachments: OAK-5740.testcase.patch, OAK-5740.testcase.patch, 
> OAK-5740.v2.patch
>
>
> As [reported|http://markmail.org/message/2qxle24f6zu2vpms] by [~catholicon] 
> on oak-dev the observation queue only delivers the so-called _overflow 
> entry/change_ only when new commits are 'coming in'. We might want to 
> consider fixing this, even though arguably this is a very rare case (since 
> typically the observation queue is configured to be very large)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to