[
https://issues.apache.org/jira/browse/OAK-5740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Saurabh updated OAK-5740:
-------------------------------
Attachment: OAK-5740.StuffAtop-v2-patch.patch
The change looks good to me (obligatory disclaimer - I'm not aware of nuances).
Have a few minor comments for
{{ObservationQueueFullWarnTest#testQueueFullThenFlushing}}:
* We should have another test section that tests that local events remain local
if the queue doesn't overflow
* switch to {{#waitFor}} instead of continuous sleep
* use {{adminSession()}} instead of {{observingSession}} to make changes
I've added those changes without s.o.println removal plus remove
keep-commits-going-to-let-obserflow-flowing hack in {{#waitFor}} in
[^OAK-5740.StuffAtop-v2-patch.patch] (that's diff over [^OAK-5740.v2.patch]).
> deliver overflow change even without new commit
> -----------------------------------------------
>
> Key: OAK-5740
> URL: https://issues.apache.org/jira/browse/OAK-5740
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
> Affects Versions: 1.6.0
> Reporter: Stefan Egli
> Assignee: Stefan Egli
> Priority: Minor
> Fix For: 1.7.0, 1.8
>
> Attachments: OAK-5740.StuffAtop-v2-patch.patch,
> OAK-5740.testcase.patch, OAK-5740.testcase.patch, OAK-5740.v2.patch
>
>
> As [reported|http://markmail.org/message/2qxle24f6zu2vpms] by [~catholicon]
> on oak-dev the observation queue only delivers the so-called _overflow
> entry/change_ only when new commits are 'coming in'. We might want to
> consider fixing this, even though arguably this is a very rare case (since
> typically the observation queue is configured to be very large)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
