[
https://issues.apache.org/jira/browse/OAK-6138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986543#comment-15986543
]
Michael Dürig commented on OAK-6138:
------------------------------------
+1 for the patch so far. Can we go further from here and make
{{LockBasedSchedulerBuilder}} return (non) {{Observable}} instances of
{{LockBasedScheduler}} depending on the value of the {{dispatchChanges}} flag
instead of having to check for {{null}} in
{{LockBasedScheduler.addObserver()}}? I think this would be the cleanest
approach conceptionally, not sure whether this complicates the implementation
too much though and it is not actually worth it.
> Remove addObserver method from Scheduler API
> --------------------------------------------
>
> Key: OAK-6138
> URL: https://issues.apache.org/jira/browse/OAK-6138
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: segment-tar
> Reporter: Andrei Dulceanu
> Assignee: Andrei Dulceanu
> Priority: Minor
> Fix For: 1.8, 1.7.3
>
> Attachments: OAK-6138.patch
>
>
> We should remove the {{addObserver()}} method from the {{Scheduler}}
> interface and instead have {{LockBasedScheduler}} implement {{Observable}}(or
> not depending on the {{dispatchChanges}} flag in
> {{LockBasedSchedulerBuilder.build()}}. {{SegmentNodeStore.addObserver()}}
> would then instance of check the scheduler for {{Observable}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
