[
https://issues.apache.org/jira/browse/OAK-6138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995045#comment-15995045
]
Michael Dürig commented on OAK-6138:
------------------------------------
I kinda like this, but I leave it to you whether you prefer this variant over
the other.
Just one thing on the side (as we are now on Java 8), we could do away with
that {{NOOP}} {{Closeable}} and just replace it with {{return () -> {};}}.
> Remove addObserver method from Scheduler API
> --------------------------------------------
>
> Key: OAK-6138
> URL: https://issues.apache.org/jira/browse/OAK-6138
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: segment-tar
> Reporter: Andrei Dulceanu
> Assignee: Andrei Dulceanu
> Priority: Minor
> Fix For: 1.8, 1.7.3
>
> Attachments: OAK-6138-02.patch, OAK-6138.patch
>
>
> We should remove the {{addObserver()}} method from the {{Scheduler}}
> interface and instead have {{LockBasedScheduler}} implement {{Observable}}(or
> not depending on the {{dispatchChanges}} flag in
> {{LockBasedSchedulerBuilder.build()}}. {{SegmentNodeStore.addObserver()}}
> would then instance of check the scheduler for {{Observable}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
