[ 
https://issues.apache.org/jira/browse/OAK-6145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992637#comment-15992637
 ] 

angela commented on OAK-6145:
-----------------------------

[~alexparvulescu], if we made 
{{MembershipWriter.DEFAULT_MEMBERSHIP_THRESHHOLD}} public, the 
{{UpgradeMembershipWriter}} would not need to extend from {{MembershipWriter}} 
and it was clear that the {{UpgradeMembershipWriter}} doesn't use any other 
functionality provided by the {{MembershipWriter}}.

One more thought: do you know of the upgrade from Jackrabbit 2.x is always to 
Oak 1.0? the reason why I am asking: in case we changed to content structure of 
the member-references, we would need to make sure to touch the upgrade code 
_if_ it was also intended to be used for direct upgrade from Jackrabbit 2.x to 
Oak > 1.6. 

> Move MembershipWriter#setMembers() to oak-upgrade
> -------------------------------------------------
>
>                 Key: OAK-6145
>                 URL: https://issues.apache.org/jira/browse/OAK-6145
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, security, upgrade
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>            Priority: Minor
>             Fix For: 1.7.0, 1.8
>
>         Attachments: OAK-6145.patch
>
>
> As suggested on OAK-6141, let's move this method to {{oak-upgrade}} as it's 
> the only place it's used.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to