Vikas Saurabh commented on OAK-6504:

[~amitjain], the fix looks good to me. A minor nitpick though - I think the 
temp file to track deleted blobs should be created in {{rootDirectory}} passed 
onto {{ActiveDeletedBlobCollectorFactory}}.

For the test, I have OAK-6334 on my plate. I'd try to refactor those later. For 
now, extracting out and creating the new class look fine to me.

> Active deletion of blobs needs to indicate information about purged blobs to 
> mark-sweep collector
> -------------------------------------------------------------------------------------------------
>                 Key: OAK-6504
>                 URL: https://issues.apache.org/jira/browse/OAK-6504
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: lucene
>    Affects Versions: 1.7.1
>            Reporter: Vikas Saurabh
>            Assignee: Amit Jain
>            Priority: Minor
>             Fix For: 1.8, 1.7.6
>         Attachments: OAK_6504.patch
> Mark sweep blob collector (since 1.6) tracks blobs in store. Active purge of 
> lucene index blobs doesn't update these tracked blobs which leads to mark 
> sweep collector to attempt to delete those blobs again.

This message was sent by Atlassian JIRA

Reply via email to