[
https://issues.apache.org/jira/browse/OAK-6318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164431#comment-16164431
]
angela commented on OAK-6318:
-----------------------------
[~stillalex], i gave it a try and found the following issues (sometimes with
proposed solutions where i have one)
h4. Package o.a.j.oak.spi.xml.*
- dependency to _plugins.nodetype_ by use of {{EffectiveNodeType}} in
{{PropInfo}} can be worked around by moving the utility method to
{{EffectiveNodeType}}
- dependency to _spi.security.*_: instead of moving _spi.xml_ to the
_oak-store-spi_ or _oak-core-spi_ module i would move it out to
_oak-security-spi_ along with the security code base.
h4. Package o.a.j.oak.spi.security.*
- {{ConfigurationUtil}} depends on impl... i would deprecate the class and for
the time being just add hardcoded strings instead of {{*.class.getName()}}.
- dependencies to constants {{NodeTypeConstants}}, {{NamespaceConstants}},
{{VersionConstants}} (etc): not sure yet what would be the best way to deal
with that.
- dependency to _o.a.j.oak.plugins.tree_: that's IMO the most troublesome
dependency because that package also contains factories that require
_oak-core_. I guess we have to rip that apart at the cost of breaking
compatibility.
- dependency to {{o.a.j.oak.namepath.NamePathMapper}}: similar as the one
before... while the interfaces {{NamePathMapper}}, {{NameMapper}},
{{PathMapper}} could safely be moved to _oak-core-spi_ the other classes in the
same package have dependencies to other plugins and (afaik) to implementation
details... maybe we also would need to split that package.
- ... (more to come as i analyse the issues)
> Refactor oak.spi.security into a separate module/bundle
> -------------------------------------------------------
>
> Key: OAK-6318
> URL: https://issues.apache.org/jira/browse/OAK-6318
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: core, security
> Reporter: angela
>
> In the light of the modularization effort it would IMHO make a lot of sense
> to refactor _oak.spi.security.*_ into a separate module/bundle that could be
> release independent of _oak-core_.
> As far as I could see so far this is currently not easily doable due to the
> dependency of {{oak.spi.security.*}} on {{oak.plugins.tree}}, which in turn
> relies on {{o.a.j.oak.query.QueryEngineSettings}} and other oak-core
> internals (see also OAK-6304). Most likely this issue would therefore require
> a complete review (and possibly a split) of the {{oak.plugins.tree}} package
> space which contains a mixture of utilities and 'API' (like e.g.
> {{TreeContext}} and {{TreeLocation}})... will open a separate issue for this
> linking to this one.
> cc: [~alex.parvulescu], [~rombert], [~mduerig], [~tmueller]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
