[
https://issues.apache.org/jira/browse/OAK-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436757#comment-16436757
]
Maksim Kviatkouski commented on OAK-6209:
-----------------------------------------
[~frm], I do really appreciate your time reviewing my patch and commenting it.
I agree on all points and have only a few points to clarify:
- I love the idea of using {{CompositeOutputStrategy}}. It will make code more
elegant indeed. I feel that "noop" strategy class may not be needed. I will
simply have one strategy inside of my {{CompositeOutputStrategy}} printing to
console instead of having both: console and csv printer. What do you think?
Just thinking out loud to make sure I understood you right.
- Totally agree on making {{BenchmarkOutputStrategy}} reusable. Now I
instantiate one or even two strategies per each test run which is absolutely
unnecessary.
- I didn't feel very good myself rewriting all those calls to {{System.out}}
only to add "if" to them. My bad, I got a bit rusty with real-world java
programming, so didn't think about this option.
All very good points, Thanks once again. I'll have patch ready in a few days.
> The benchmark runner should produce machine-friendly output
> -----------------------------------------------------------
>
> Key: OAK-6209
> URL: https://issues.apache.org/jira/browse/OAK-6209
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: benchmarks
> Reporter: Francesco Mari
> Assignee: Francesco Mari
> Priority: Major
> Attachments: oak-6209.patch, sample-machine-readable-output.txt
>
>
> The benchmark runner currently produce output in the following format.
> {noformat}
> Apache Jackrabbit Oak 1.8-SNAPSHOT
> # LoginTest C min 10% 50% 90% max
> N
> Oak-Segment-Tar 1 472 494 522 552 631
> 115
> # LoginLogoutTest C min 10% 50% 90% max
> N
> Oak-Segment-Tar 1 472 479 513 543 568
> 118
> {noformat}
> While this format is well formatted and easy to read, it's a pain to process
> with standard command line utilities. The benchmark runner should give the
> possibility to produce machine-friendly output, like the following.
> {noformat}
> LoginTest,Oak-Segment-Tar,1,472,494,522,552,631,115
> LoginLogoutTest,Oak-Segment-Tar,1,472,479,513,543,568,118
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
