[ 
https://issues.apache.org/jira/browse/OAK-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439073#comment-16439073
 ] 

Francesco Mari commented on OAK-6209:
-------------------------------------

[~maksim_kviatkouski], the patch looks very good. I think that there are only a 
couple of points left to consider, and they are quite trivial.

In order to not break any other functionality, {{ScalabilityRunner}} needs to 
be fixed as part of this patch. Because {{ScalabilityRunner}} is not yet fixed 
{{AbstractTest#csvStrategy}} is set by {{AbstractTest#setPrintStream}} but it's 
never used. This problem will go away as soon as {{ScalabilityRunner}} is fixed.

Moreover, the patch should contain some unit tests for the newly introduced 
code, especially for the output strategies.

> The benchmark runner should produce machine-friendly output
> -----------------------------------------------------------
>
>                 Key: OAK-6209
>                 URL: https://issues.apache.org/jira/browse/OAK-6209
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: benchmarks
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>            Priority: Major
>         Attachments: oak-6209.patch, oak-6209.patch, 
> sample-machine-readable-output.txt
>
>
> The benchmark runner currently produce output in the following format.
> {noformat}
> Apache Jackrabbit Oak 1.8-SNAPSHOT
> # LoginTest                        C     min     10%     50%     90%     max  
>      N 
> Oak-Segment-Tar                    1     472     494     522     552     631  
>    115
> # LoginLogoutTest                  C     min     10%     50%     90%     max  
>      N 
> Oak-Segment-Tar                    1     472     479     513     543     568  
>    118
> {noformat}
> While this format is well formatted and easy to read, it's a pain to process 
> with standard command line utilities. The benchmark runner should give the 
> possibility to produce machine-friendly output, like the following.
> {noformat}
> LoginTest,Oak-Segment-Tar,1,472,494,522,552,631,115
> LoginLogoutTest,Oak-Segment-Tar,1,472,479,513,543,568,118
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to