[
https://issues.apache.org/jira/browse/OAK-7410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519185#comment-16519185
]
Thomas Mueller commented on OAK-7410:
-------------------------------------
I wanted to remove the oak-lucene IndexDefinitionBuilder, as that exists in
oak-search. But there are two differences:
* the oak-lucene impl sets "compatVersion" = 2, while the oak-search one doesn't
* the oak-lucene impl sets "type" = "lucene", while the oak-search one sets
"type" = "fulltext"
The compatVersion, I think we should set it to 2.
The type, I'm not sure. The class is final, so how to use a different type?
* Remove "final" and allow to extend the class, eg. in lucene - I don't prefer
that - I would rather use encapsulation than extension.
* Maybe the type could be set to the right impl ("lucene", "solr") AFTER the
config is done.
> Define SPIs for Oak Search module
> ---------------------------------
>
> Key: OAK-7410
> URL: https://issues.apache.org/jira/browse/OAK-7410
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Reporter: Tommaso Teofili
> Assignee: Tommaso Teofili
> Priority: Major
> Fix For: 1.9.3
>
> Attachments: AggregateGenerics.patch
>
>
> Abstract IndexEditor and QueryIndex implementations and SPIs should be
> created for Oak Search module.
> Those classes should be then reused / extended by implementors in and outside
> Oak .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
