[ 
https://issues.apache.org/jira/browse/OAK-7570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519938#comment-16519938
 ] 

Julian Reschke edited comment on OAK-7570 at 6/26/18 9:42 AM:
--------------------------------------------------------------

>From an [email on oak-dev|https://markmail.org/message/g6cymwquxuy5h2tj] from 
>[~mreutegg]:
{quote}If the BlobStore implements HttpBlobProvider register it with 
 that interface as well and use it to construct the repository. Something 
 like:


 BlobStore bs = ...
 NodeStore ns = ...
 Jcr jcr = new Jcr(ns)
 if (bs instanceof HttpBlobProvider)
 jcr.with((HttpBlobProvider) bs)
 Repository r = jcr.createRepository()


 By default, the Jcr factory would have a HttpBlobProvider implementation 
 that doesn't support the feature, which also relieves the repository 
 implementation from checking the type or for null on every call to the 
 new feature (as is the case in SessionImpl, MutableRoot, 
 DocumentNodeStore, SegmentNodeStore)
{quote}
 


was (Author: mattvryan):
>From an [email on oak-dev|https://markmail.org/message/g6cymwquxuy5h2tj] from 
>[~mreutegg]:
{quote}If the BlobStore implements HttpBlobProvider register it with 
 that interface as well and use it to construct the repository. Something 
 like:
{{BlobStore bs = ... }}
{{ NodeStore ns = ... }}
{{ Jcr jcr = new Jcr(ns) }}
{{ if (bs instanceof HttpBlobProvider) }}
{{ jcr.with((HttpBlobProvider) bs) }}
{{ Repository r = jcr.createRepository()}}
By default, the Jcr factory would have a HttpBlobProvider implementation 
 that doesn't support the feature, which also relieves the repository 
 implementation from checking the type or for null on every call to the 
 new feature (as is the case in SessionImpl, MutableRoot, 
 DocumentNodeStore, SegmentNodeStore)
{quote}
 

> [DirectBinaryAccess][DISCUSS] Client access via DataStoreBlobStore directly
> ---------------------------------------------------------------------------
>
>                 Key: OAK-7570
>                 URL: https://issues.apache.org/jira/browse/OAK-7570
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: blob-plugins
>            Reporter: Matt Ryan
>            Assignee: Matt Ryan
>            Priority: Major
>
> Open discussion related to OAK-7569:
> The [original pull request|https://github.com/apache/jackrabbit-oak/pull/88] 
> proposes changes to oak-api, oak-segment-tar, oak-store-document, oak-core, 
> and oak-jcr as well as oak-blob-plugins, oak-blob-cloud, and oak-blob-azure.  
> Would it be possible / better to keep the changes local to the oak-blob-* 
> bundles and avoid making changes throughout the stack?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to