[
https://issues.apache.org/jira/browse/OAK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818691#comment-16818691
]
Alex Deparvu commented on OAK-8234:
-----------------------------------
bq. Also: I would like the new class AllPermissionProviderImpl to come with a
dedicated test class with unit tests. Also an extra test for
AuthorizationConfigurationImpl...
sure, I'll wait for the outcome of OAK-8240 to continue working on this patch.
bq. if the distinction between administrative and non-administrative principal
set is taken care of in AuthorizationConfigurationImpl shouldn't we remove that
check then in PermissionProviderImpl? Also: isn't AllPermissions then redundant
and should be removed?
Given the current evolution of the patch (it's now completely decoupled from
the PermissionProviderImpl), I would prefer to not touch that part at all.
> Reduce object allocation in PermissionProviderImpl for admin sessions
> ---------------------------------------------------------------------
>
> Key: OAK-8234
> URL: https://issues.apache.org/jira/browse/OAK-8234
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, security
> Reporter: Alex Deparvu
> Assignee: Alex Deparvu
> Priority: Major
>
> There was already a lot of work done here to improve efficiency of admin
> sessions, but we can still do better by simply not creating many of the
> objects needed as parameters for the {{CompiledPermissions}} which will be
> ignored anyway in the case of admin sessions.
> Ex: There are a lot of immutable trees (created via
> {{PermissionUtil.getReadOnlyTree(tree, immutableRoot)}}) that are not used
> for the evaluation.
> Thanks to [~mreutegg] for spotting this one!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
