[ 
https://issues.apache.org/jira/browse/OAK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825176#comment-16825176
 ] 

angela commented on OAK-8234:
-----------------------------

[~stillalex], looks good. regarding the test: it's now present for the admin 
session and for the test session (where the original behavior is tested) so we 
are good adjusting the test for admin. thanks a lot for your patience!

> Reduce object allocation in PermissionProviderImpl for admin sessions
> ---------------------------------------------------------------------
>
>                 Key: OAK-8234
>                 URL: https://issues.apache.org/jira/browse/OAK-8234
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, security
>            Reporter: Alex Deparvu
>            Assignee: Alex Deparvu
>            Priority: Major
>             Fix For: 1.14.0
>
>
> There was already a lot of work done here to improve efficiency of admin 
> sessions, but we can still do better by simply not creating many of the 
> objects needed as parameters for the {{CompiledPermissions}} which will be 
> ignored anyway in the case of admin sessions.
> Ex: There are a lot of immutable trees (created via 
> {{PermissionUtil.getReadOnlyTree(tree, immutableRoot)}}) that are not used 
> for the evaluation.
> Thanks to [~mreutegg] for spotting this one!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to