[
https://issues.apache.org/jira/browse/OAK-7671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046750#comment-17046750
]
Thomas Mueller commented on OAK-7671:
-------------------------------------
Github has some issues currently according to https://www.githubstatus.com/
For me the patch looks good.
For the method "encodeId", it would be good to add some comments on what it is
doing and some example input and output. It's very hard to understand right
now. But this was the case before, and is not related to the patch. If you
already know some details (maybe by debugging), it would be good to add the
info. It doesn't need to be a Javadoc:
{noformat}
/**
* Encode the ... and extract the ...
* Example:
* .... => ...
* .... => ...
*/
static String encodeId(String line, BlobStoreOptions.Type dsType) {
// 0102030405... => 01/02/03/0102030405...
blobId = (blobId.substring(0, 2) + FILE_SEPARATOR.value() +
blobId.substring(2, 4) + FILE_SEPARATOR.value() + blobId
.substring(4, 6) + FILE_SEPARATOR.value() + blobId);
// 0102030405... => 0102-030405...
blobId = (blobId.substring(0, 4) + DASH + blobId.substring(4));
if (list.size() > 1) {
// ( this part I don't understand... why list.get(1)? what does it do?)
return delimJoiner.join(blobId,
EscapeUtils.unescapeLineBreaks(list.get(1)));
{noformat}
> [oak-run] Deprecate the datastorecheck command in favor of datastore
> --------------------------------------------------------------------
>
> Key: OAK-7671
> URL: https://issues.apache.org/jira/browse/OAK-7671
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: run
> Reporter: Amit Jain
> Assignee: Nitin Gupta
> Priority: Major
> Fix For: 1.26.0
>
>
> With the introduction of \{{datastore}} command which supports both garbage
> collection as well as consistency check the \{{datastorecheck}} command
> should be deprecated and delegated internally to use that implementation.
> Besides some options which are currently not supported by the new command
> should also be implemented e.g. --ids, --refs
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
