[ 
https://issues.apache.org/jira/browse/OAK-7671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051801#comment-17051801
 ] 

Nitin Gupta commented on OAK-7671:
----------------------------------

Updated the final PR with tests 
[https://github.com/oak-indexing/jackrabbit-oak/pull/45/files] .

 

To sum up, this is what's done -
 # Added operations to dump id and dump references in the new DataStore Command
 # Added a regex option to be used along with --verboseRootPath , this should 
limit the number of nodes that need to be scanned/traversed (useful if we know 
a the specific type of paths that we need to scan for blob references , for 
example in case of lucene blobs it is /oak:index/*/:data and 
/oak:index/*/:suggest-data)
 # Added the tests around the above 2 points and a few small changes in the 
test code.

 

I see , [~thomasm]  already approved the main code changes in PR (post that I 
only added the tests).

 

I will merge by EOD today, but further reviews are still welcome.

 

cc : [~amitjain]  , [~tihom88] , [~fabrizio.fort...@gmail.com]

> [oak-run] Deprecate the datastorecheck command in favor of datastore
> --------------------------------------------------------------------
>
>                 Key: OAK-7671
>                 URL: https://issues.apache.org/jira/browse/OAK-7671
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: run
>            Reporter: Amit Jain
>            Assignee: Nitin Gupta
>            Priority: Major
>             Fix For: 1.26.0
>
>
> With the introduction of \{{datastore}} command which supports both garbage 
> collection as well as consistency check the \{{datastorecheck}} command 
> should be deprecated and delegated internally to use that implementation. 
> Besides some options which are currently not supported by the new command 
> should also be implemented e.g. --ids, --refs



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to