[
https://issues.apache.org/jira/browse/OAK-9246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241319#comment-17241319
]
Angela Schreiber commented on OAK-9246:
---------------------------------------
[~mreutegg], my primary concern was about getting a review for the proposed
extension in _oak-core-spi_, because i don't maintain that code base. for the
security-related parts of the patch I feel confident to change it. any idea on
who is responsible for the stats package in _oak-core-spi_?
> Avoid hardcoding stats classes in SecurityProviderRegistration
> --------------------------------------------------------------
>
> Key: OAK-9246
> URL: https://issues.apache.org/jira/browse/OAK-9246
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, security, security-spi
> Reporter: Angela Schreiber
> Assignee: Angela Schreiber
> Priority: Major
> Attachments: OAK-9246.patch
>
>
> OAK-8102 introduce a single {{LoginModuleStats}} to collect unexpected errors
> during the repository login. the corresponding monitor and mbeans are
> registered in the {{SecurityProviderRegistration}} after creating the
> {{SecurityProvider}} instance.
> instead of 'hardcoding' the stats in {{SecurityProviderRegistration}}, i
> would suggest to come up with a mechanism that allows individual security
> modules to register statistics related monitors and mbeans as needed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
