[ 
https://issues.apache.org/jira/browse/OAK-9246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260383#comment-17260383
 ] 

Marcel Reutegger commented on OAK-9246:
---------------------------------------

There are quite a few package export versions that had to be bumped, but I 
guess that's simply necessary. The only alternative I see, is moving the 
responsibility for the monitors to the implementing classes. But this means, 
they would have to know the Whiteboard. It is probably better to do this 
centrally as proposed in the patch.

> Avoid hardcoding stats classes in SecurityProviderRegistration
> --------------------------------------------------------------
>
>                 Key: OAK-9246
>                 URL: https://issues.apache.org/jira/browse/OAK-9246
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, security, security-spi
>            Reporter: Angela Schreiber
>            Assignee: Angela Schreiber
>            Priority: Major
>         Attachments: OAK-9246.patch
>
>
> OAK-8102 introduce a single {{LoginModuleStats}} to collect unexpected errors 
> during the repository login. the corresponding monitor and mbeans are 
> registered in the {{SecurityProviderRegistration}} after creating the 
> {{SecurityProvider}} instance.
> instead of 'hardcoding' the stats in {{SecurityProviderRegistration}}, i 
> would suggest to come up with a mechanism that allows individual security 
> modules to register statistics related monitors and mbeans as needed. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to