On Thu, 16 Nov 2017 00:42:09 +0000 Changwei Ge <ge.chang...@h3c.com> wrote:
> Hi Zhonghua, > On 2017/11/15 20:04, Guozhonghua wrote: > > The goto is not useful anymore, removed from the context. > > Perhaps we can make this change-log more clear like: > The bail declare is not necessary any more, so trim it. If code path > falls into error branch, ocfs2_reserve_cluster_bitmap_bits will return > in next following step, too. > > And this title can be changed into 'ocfs2: clean up unnecessary bail > declare' > > I suppose after that this patch will be neater. > > Can you resend this patch? > Moreover, I think we should also CC this patch to OCFS2 maintainers. The patch is OK. I reworked it as below. It's so obvious that no changelog is needed. From: Guozhonghua <guozhong...@h3c.com> Subject: ocfs2: remove unneeded goto in ocfs2_reserve_cluster_bitmap_bits() Link: https://urldefense.proofpoint.com/v2/url?u=http-3A__lkml.kernel.org_r_71604351584F6A4EBAE558C676F37CA4F3CDE3A9-40H3CMLB14-2DEX.srv.huawei-2D3com.com&d=DwICAg&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=C7gAd4uDxlAvTdc0vmU6X8CMk6L2iDY8-HD0qT6Fo7Y&m=lcqqp5PvLSjaJ5MT6uqUC9J6gAhx8KP5Fd62d4ii4BA&s=KqlZy8JoC39DDT5b_TM6C12Vtg7AZhEE0QsYSC9ZJ30&e= Signed-off-by: guozhonghua <guozhong...@h3c.com> Cc: Mark Fasheh <mfas...@versity.com> Cc: Joel Becker <jl...@evilplan.org> Cc: Junxiao Bi <junxiao...@oracle.com> Cc: Joseph Qi <jiangqi...@gmail.com> Signed-off-by: Andrew Morton <a...@linux-foundation.org> --- fs/ocfs2/suballoc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff -puN fs/ocfs2/suballoc.c~ocfs2-the-goto-is-not-useful-in-the-function-ocfs2_reserve_cluster_bitmap_bits-so-remove-it fs/ocfs2/suballoc.c --- a/fs/ocfs2/suballoc.c~ocfs2-the-goto-is-not-useful-in-the-function-ocfs2_reserve_cluster_bitmap_bits-so-remove-it +++ a/fs/ocfs2/suballoc.c @@ -1147,12 +1147,9 @@ int ocfs2_reserve_cluster_bitmap_bits(st GLOBAL_BITMAP_SYSTEM_INODE, OCFS2_INVALID_SLOT, NULL, ALLOC_NEW_GROUP); - if (status < 0 && status != -ENOSPC) { + if (status < 0 && status != -ENOSPC) mlog_errno(status); - goto bail; - } -bail: return status; } _ _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel
