Hi,
ons, 27 02 2008 kl. 13:37 +0100, skrev Eric Chassande-Mottin:
> I'd like to register as an OctaveForge developer.
> I can contribute a few codes that may be useful
> for improving Octave compatibility with Matlab.
> One of those is the implementation of sosfilt.cc
> attached to this message.
It seems the attachment was dropped (this happens sometimes on this
list, haven't figured out why). I assume it's the same code you sent to
the help list -- is that correct?
> I have created an account on sourceForge.
> please, let me know for the next step.
What is your account name? Tell me, and I can give you commit access. I
guess your code should end up in the 'signal' package...
Anyway, I have a few comments to the code. I only had a quick look, but
a few things popped up.
*) You should add a version to the GPL. Since Octave is licensed under
GPLv3 or later, I recommend that you do the same.
*) You type 'using namespace std' two times.
*) You should as a minimum state what arguments you function accepts,
and what it returns, in the help text. But it would be nice if you
wrote something more elaborate.
*) You need to handle the situation where the user supplies input arguments
of the wrong type (as an example, I think your code will crash Octave if
your function is called with a 'struct' as input). You can check this using
if (error_state) { error("Bad input"); return octave_value_list; }
after extracting values from an octave_value.
Søren
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Octave-dev mailing list
Octave-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/octave-dev
