The new version (0.0.2) is at http://www.slackydeb.altervista.org
2008/3/12, David Bateman <[EMAIL PROTECTED]>: > Some comments on the code > > The files in src/ga and src/ieee754 should all be included in the inst/* > directory... The internal functions should start with a double "_" and > treminate with a double "_" for consistency with the rest of Octave. > That is _ga_calcola_img_fitnessfcn.m should be > __ga_calcola_img_fitnessfcn__.m. Are the functions > > crossoversinglepoint.m > gacreationuniform.m > mutationsinglepoint.m > selectionroulette.m This are public functions defined in Matlab doc, except for mutationsinglepoint (but I prefer keeping mutationsinglepoint public, in analogy to mutationgaussian and mutationuniform in Matlab doc). > ieee754_bitstring2double.m > ieee754_double2bitstring.m > > Also internal functions? If so they should also have trailing and > leading __ characters in their names. Yes, internal functions. Done in the new version. __ieee754_bitstring2double__.m obtains a double from its ieee754 bit string. Is there already any function in Octave/Octave-Forge to do this? If yes, I could remove a lot of code from this function. If not, could it be useful as a public function out of this (ga) package (that is, in the core Octave or in another package in Octave-Forge)? > It would be better if the test/demo code you have was included directly > into the files. Ok. I modified the demo in __ieee754_bitstring2double__.m to become tests. I removed a test in ga.m; I leaved only some simple tests. > The functions are also noisy in that there appears to be > missing ";" and so some lines return values when they shouldn't. Can we > get rid of the plot as well if nargout > 0... Removed the noise. Completely removed the plot (it was there only for my tests; I should implement plots as documented in Matlab doc). > There are a number of other style issues (indentation, commenting, etc) > that would make it more Octave compatible, but that is not necessary. > > In any case, please find attached a modified version of how I see it > might be packaged for octave-forge.. Note the ga-0.0.1 directory should > become ga in the octave-forge SVN. The command > > pkg install ga-0.0.1.tar.gz > > should install this repackaged files in octave correctly. I reviewed and modified a bit the files INDEX and DESCRIPTION. > > > D. > > -- > David Bateman [EMAIL PROTECTED] > Motorola Labs - Paris +33 1 69 35 48 04 (Ph) > Parc Les Algorithmes, Commune de St Aubin +33 6 72 01 06 33 (Mob) > 91193 Gif-Sur-Yvette FRANCE +33 1 69 35 77 01 (Fax) > > The information contained in this communication has been classified as: > > [x] General Business Information > [ ] Motorola Internal Use Only > [ ] Motorola Confidential Proprietary > > > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Octave-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/octave-dev
