Citi, Luca wrote: > Dear David Bateman, > I am an octave user. I write you because you committed a change to the > filtfilt function lately. > I found a problem with filtfilt. I posted a message to the octave-dev mailing > list on Nov 3rd. > http://sourceforge.net/mailarchive/message.php?msg_name=3DA3B328CBC48B4EBB88484B8A5EA191064C547A%40sernt14.essex.ac.uk > I think you might be interested in investigating it deeper. > Thank you for your efforts in open-source software. > Regards, > Luca Citi > > > In fact I tend to touch all code and not just that I'm interested in, mainly for maintenance of the code for others of prior to release.. In fact filtfilt is not a function I personally use and so I'd have to rely on the advice of others.
However, the basic premise of octave-forge is that if you have code that addresses a bug and no one comments on your message, then you've inherited that function. The code you sent however has a few issues with replacing the existing filtfilt function * No copyright or help string. Check the original filtfilt function and take that * The style is matlab like rather than the style of other Octave code (endif, etc) * You don't do the estimate of the initial vector and iteration of the original code and so performance is not the same Could you comment and perhaps it might be an also comment on the matlab compatibility of this code and supply a few example demonstrating the compatibility (cf the %!test and %!assert comments in other octave m-files) Regards David -- David Bateman dbate...@dbateman.org 35 rue Gambetta +33 1 46 04 02 18 (Home) 92100 Boulogne-Billancourt FRANCE +33 6 72 01 06 33 (Mob) ------------------------------------------------------------------------------ SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ _______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev
