> > Ok, I think it's good now :)
> 
> Thanks. Since nobody has commented, I assume people think your stuff is
> good :-)
> 
> I've (hopefully) made the documentation somewhat more clear, and changed
> the coding-style a bit. Could you check that I haven't broken anything?
> I'm attaching the code.

I've tried it now, and I think the code is buggy:

A.
        x=-pi:0.01:pi; y=cos(x);
        plot(x,y)
        fwhm(x,y)
=> FWHM is pi, but the script returns 2.094

B.
        x=-pi:0.01:pi; y=cos(x) + 5;
        plot(x,y)
        fwhm(x,y)
=> FWHM is pi, but the script says "full width at half maximum is not 
=> defined.".

It looks like the script works not between min and max values of the curve 
(x,y), but between max(y) and zero. That's wrong and contrary to its 
documentation.

I think that "#!test" case should be added.

Further, could it produce vector of fwhm's for matricial f in fwhm(x,f)?

Greetings,
  Petr

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Octave-dev mailing list
Octave-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/octave-dev

Reply via email to