On Fri, Oct 2, 2009 at 2:49 PM, Pete Gonzalez <[email protected]> wrote:
> Hi Søren,
>

Hi,

> Attached is an updated version of cl2bp.cc with the following changes:
>
> - As requested, I added error_state checks for the input parameters. BTW I
> noticed that a lot of shipping Octave code is missing these checks; it
> should probably be audited at some point.
>
> - The MallocArray class you asked about was intended to support LGPL
> scenarios, i.e. where people can't use the GPL'ed oct.h.  That code is now
> isolated with a CL2BP_STANDALONE switch.  In a normal build, the native
> ColumnVector/Array classes are now used, but with C-style indexing
> operators.  (I didn't convert x[i] to x(i) everywhere because I think it
> would hinder readability.)
>

First the legal thing:
I'm afraid GPL can't be worked around as easily as you think (if it
could, dozens of companies would instantly do it). If you use Octave's
C++ API within your code, your code becomes a derived work of Octave
and hence its license needs to comply with GPL, use of LGPL is not
possible. It doesn't matter that the Octave-derived part can be
switched off by a directive. Even if it was commented out, GPL would
still apply.
In the present form, it can only be included in OctaveForge if you
accept changing the license to GPL.
If you really want a LGPL part, a possible way out is to isolate the
library from the Octave interface and distribute them separately
(In OctaveForge, they can be put together, but the license will become GPL).

Then the technical thing:
is rmmult really doing a matrix-matrix multiply? If yes, what are the
typical dimensions? For anything bigger than small (left vague), it
will probably be worth to defer this operation to BLAS to gain
performance.

hth

-- 
RNDr. Jaroslav Hajek
computing expert & GNU Octave developer
Aeronautical Research and Test Institute (VZLU)
Prague, Czech Republic
url: www.highegg.matfyz.cz

------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf
_______________________________________________
Octave-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/octave-dev

Reply via email to