2011/11/2 Carnë Draug <carandraug+...@gmail.com>: > 2011/10/21 c. <carlo.defa...@gmail.com>: >> On 21 Oct 2011, at 19:28, Carnë Draug wrote: >>> Hmm.... you think it's really worth keep it in octave-forge if the >>> difference in speed is that small? >> >> Your're right I'm not sure it's worth the effort of maintaining an extra >> function, so it's OK if you remove it >> >>> And if we were to remove it (and even if not, I'd like to know how to >>> do this), do you know how to mark C++ functions deprecated? I think >>> that for m functions is enough to move them into a deprecated >>> directory, but what about these cases? Thanks >> >> I'm not really sure and I cannot test at the moment, but >> I think the .oct file should go into "deprecated" > > It seems this doesn't work for packages so I simply made the function > give a warning about being deprecated when used. Also, I used the > -Wall flag and installing the package now returns a few warnings. > > gsvd.cc: In function ‘octave_value_list Fgsvd(const octave_value_list&, int)’: > gsvd.cc:191: warning: unused variable ‘nn’ > pgmres.cc: In member function ‘virtual ColumnVector > matrixfreematrixfun::operator*(ColumnVector)’: > pgmres.cc:227: warning: control reaches end of non-void function > pgmres.cc: In function ‘octave_value_list Fpgmres(const > octave_value_list&, int)’: > pgmres.cc:95: warning: ‘A’ may be used uninitialized in this function > pgmres.cc:95: warning: ‘invP’ may be used uninitialized in this function
Thanks to Juan Carbajal (KaKiLa) in #octave, for helping getting rid of these. It should now compile with no warnings. Carnë ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev
