On 20111108@15:12, Carlo de Falco wrote: > Michele, > > This sounds indeed like a nice contribution! > > I might try to help check the code but currently > I really have very little spare time, so if someone else > jumps in it would defenitely make things happen faster. Hi Carlo,
Thanks for the "check" offer! I remain in listening mode then, waiting for more responses/checks. That "License:" line was incorrect (it was copied from some other package DESCRIPTION); now fixed to "License: GPLv3". > Anyway here is a few quick comments: > > I see in the DESCRIPTION file: > > License: LGPL, see individual files for GPL version > > Do you intend to use GPL or LGPL? As far as I know, LGPL is more appropriate for libraries, while GPL for full programs. For this reason, the "librsb" source archives can be distributed separately under the LGPL (it's slightly more permissive than GPL, as far as I understand). Now, the "sparsersb" archive actually contains sources for the OCT-function only. However for technical reasons (so far, "sparsersb" links to "librsb" statically), it may arise the need for packaging "sparsersb" with the "librsb" sources, all in one file; in such a case maybe LGPL would be the right choice. > I think for m-files and for c files that do not link to Octave internals you > can use whatever you like, > but any .oct file will link to Octave internals so, as Octave is GPLv3, it > must be GPLv3 as well. By analogy to the various third party libraries distributed "verbatim" in Octave, I see that if their licensing is more liberal (e.g.: BSD/LGPLv3) it's also OK, right ? > On 8 Nov 2011, at 13:00, Michele Martone wrote: > > > Essentially, the "librsb" library is almost ready for a release and it > > only needs more "early users" for a wider testing. > > The "sparsersb" Octave plugin/type is quite functional, although I think > > some expert Octave developer should give a look at it --- I am not even > > sure how much it is "legal" to introduce a new Octave type by mimicking > > the Octave internals/headers (as I did). > > There is an example of the correct way to create a new octave matrix class in > the package "triangular": > > http://octave.svn.sourceforge.net/viewvc/octave/trunk/octave-forge/extra/triangular/ OK I'll check it out to see if there is something I've missed in "sparsersb". > > I am not even sure whether/how much having OpenMP usage from within > > librsb is safe in the wider context of Octave. > > liboctave is not (yet) thread safe, so if you access liboctave class methods > from within the > parallel section of your code that might create issues, but if you only use > classes defined by > yourself it should work ... It's OK then: no dependencies from Octave in librsb, and no parallel sections in "sparsersb". > c. m.
pgpfCnkn6LNsI.pgp
Description: PGP signature
------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev
