On 25 November 2011 22:58, Lukas Reichlin <lukas.reich...@gmail.com> wrote:
> On 25.11.2011, at 11:44, Olaf Till wrote:
>> On Thu, Nov 24, 2011 at 06:21:41PM +0000, Carnë Draug wrote:
>>> On 24 November 2011 18:13, Olaf Till <olaf.t...@uni-jena.de> wrote:
>>>> On Thu, Nov 24, 2011 at 02:33:25PM +0000, Carnė Draug wrote:
>>>>> On 24 November 2011 13:14, Lukas Reichlin <lukas.reich...@gmail.com>
>>>>> wrote:
>>>>>> On 24.11.2011, at 13:53, Carnė Draug wrote:
>>>>>>> On 24 November 2011 08:07, Lukas Reichlin <lukas.reich...@gmail.com>
>>>>>>> wrote:
>>>>>>>> On 20.11.2011, at 22:11, Carnė Draug wrote:
>>>>>>>>> 2011/11/20 Lukas Reichlin <lukas.reich...@gmail.com>:
>>>>>>>>>> On 20.11.2011, at 21:11, Carnė Draug wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi everyone,
>>>>>>>>>>>
>>>>>>>>>>> a recent change in octave core (in pkg.m and news.m) will allows
>>>>>>>>>>> users
>>>>>>>>>>> to read the NEWS file of packages from the octave prompt too. For
>>>>>>>>>>> example, news("signal") would show the NEWS from the signal package
>>>>>>>>>>> instead of the core NEWS.
>>>>>>>>>>>
>>>>>>>>>>> For the new functionality to happen, the NEWS file needs to be in
>>>>>>>>>>> the
>>>>>>>>>>> root of the package. However, some of the packages in octave-forge
>>>>>>>>>>> have this file in doc/. As such, I'm moving them.
>>>>>>>>>>>
>>>>>>>>>>> Other less common files that pkg recognizes during package
>>>>>>>>>>> installation are ONEWS (for when the NEWS file becomes too long) and
>>>>>>>>>>> ChangeLog (a much more detailed description of changes on each
>>>>>>>>>>> release. Something like the output of svn log).
>>>>>>>>>>>
>>>>>>>>>>> Carnė
>>>>>>>>>>
>>>>>>>>>> Hi Carnė
>>>>>>>>>>
>>>>>>>>>> The control package is one of these. Go ahead, but please make sure
>>>>>>>>>> that the Makefile is adapted accordingly such that the NEWS file
>>>>>>>>>> doesn't get lost by installation.
>>>>>>>>>>
>>>>>>>>>> Lukas
>>>>>>>>>
>>>>>>>>> Well remembered. Most packages don't have one, I had forgot about it.
>>>>>>>>> Should be fixed now. Thanks
>>>>>>>>>
>>>>>>>>> Carnė
>>>>>>>>
>>>>>>>> I downloaded the GNU Tarball from [1] and installed the package.
>>>>>>>> Unfortunately, the NEWS file still gets lost upon package
>>>>>>>> installation. Could you please fix that?
>>>>>>>>
>>>>>>>> Lukas
>>>>>>>>
>>>>>>>> PS: IIRC I had similar problems some time ago. This must have been the
>>>>>>>> reason why I put NEWS into /doc.
>>>>>>>
>>>>>>> What version are you using? This will only work in 3.6.0 (should be
>>>>>>> release pretty soon) or currently in the dev version. If you want to
>>>>>>> test it without compiling the dev version, you can replace the pkg.m
>>>>>>> and news.m files from you current installation
>>>>>>>
>>>>>>> http://hg.savannah.gnu.org/hgweb/octave/file/c3c8f513cf1f/scripts/pkg/pkg.m
>>>>>>> http://hg.savannah.gnu.org/hgweb/octave/file/c3c8f513cf1f/scripts/miscellaneous/news.m
>>>>>>>
>>>>>>> You need to use the modified pkg because it identifies the NEWS file
>>>>>>> and moves it into the packinfo dir. The modified news then allows you
>>>>>>> read the news from the prompt.
>>>>>>>
>>>>>>> Carnė
>>>>>>
>>>>>> I'm using 3.4.3. Is there a way to tell Octave 3.4 that it should move
>>>>>> NEWS to packinfo upon installation? Currently NEWS gets lost (neither
>>>>>> control-2.2.1/ nor control-2.2.1/doc nor control-2.2.1/packinfo) and I
>>>>>> would like to have a solution for Octave 3.4 series. (I'd like to
>>>>>> provide 3.4 users with the NEWS file and I don't want to increase the
>>>>>> required octave version to 3.6 just because of that.)
>>>>>>
>>>>>> Thanks for your help,
>>>>>> Lukas
>>>>>
>>>>> Hmm... When I made that change I just assumed that the only time
>>>>> people look into the doc directory is after downloading the package
>>>>> before installation. I didn't even knew the doc directory was being
>>>>> copied during install until I looked into pkg to add support for this.
>>>>> My worries was that users would stop seeing this information now that
>>>>> they can use -forge to install packages without downloading it
>>>>> themselves.
>>>>>
>>>>> For your question, one solution is to move NEWS back to doc/ and use
>>>>> post_install.m to move the file to packinfo. However, another plan I
>>>>> have later is to make a patch that will make pkg offer to show the
>>>>> NEWS file after install if a NEWS file is identified. If you do this,
>>>>> the NEWS file won't be seen by pkg and it wouldn't "offer" to show it.
>>>>> But this doesn't exist yet...
>>>>>
>>>>> Another idea which I like more is to have the NEWS file in both the
>>>>> root directory and use post_install.m to remove the file from doc if
>>>>> version > 3.6.0.
>>>>>
>>>>> Carnė
>>>>
>>>> One could try to use autoconf to detect the Octave version and copy
>>>> the NEWS file, but that is probably too much work for this issue.
>>>>
>>>> Wouldn't a symlink do the trick? I.e. make NEWs in doc/ be a symlink
>>>> to ../packinfo/NEWS (which is dangling while in the SVN repository,
>>>> but should be valid after installation)?
>>>>
>>>> Olaf
>>>
>>> I don't understand the first idea. And the second seems that it won't
>>> work for non unix systems. I've heard that Windows doesn't have
>>> symlinks. Maybe it has some other system for links? Anyone that uses
>>> windows knows about it?
>>>
>>> Carnë
>>
>> I had not much time to think about it, but I felt a bit responsible,
>> since I argued for NEWS in root directory. Here is a patch for src/Makfile
>> which should do the trick without much complications. It checks for
>> Octave version < 3.6.0 and moves NEWS from / to /src/ in this case.
>>
>> Olaf
>>
>> <Makefile.patch>
>
> Thanks for your patch, Olaf. It works for me under octave 3.4.3. Could
> someone please confirm for 3.6 that NEWS lands in the root directory? The
> updated package can be downloaded from the following link:
> http://octave.svn.sourceforge.net/viewvc/octave/trunk/octave-forge/main/control/?view=tar
>
> Best regards,
> Lukas
>
I'm using 3.4.3 but with the modified pkg.m and news.m. It worked fine
and installed the NEWS file in the packinfo directory (I had to change
the MakeFile so that the comparison would be for less than 3.4.3). The
news function could find the file with no problem.
Carnë
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Octave-dev mailing list
Octave-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/octave-dev
