On 12 April 2012 16:38, Richardson, Anthony <a...@evansville.edu> wrote: > I've attached > >> From: Carnë Draug >> Sent: Thursday, April 12, 2012 6:38 AM >> On 10 April 2012 14:37, Richardson, Anthony wrote: >> > I noticed the current release of the Comm package does not contain a >> > convolutional encoder (convenc). I wrote a very simple implementation >> > that may provide a starting point for a more full-featured one. Even >> > as-is, I've found it very useful when working through some academic >> > exercises using conv. encoders. This implementation is NOT compatible >> > with MATLAB's convenc (more work required). >> > >> > Two simple examples are included in the comments at the top of the m- >> file. >> > >> > Feel free to include this in the comm package (or not). >> > >> > Regards >> > Tony Richardson >> >> Hi Tony >> >> thank for the contribution. However, we can't accept it unless you specify a >> license. Can I suggest GPL? It's the most used on octave-forge and octave >> itself is licensed under GPL as well. Simply add the same header on this >> function ( http://octave.svn.sourceforge.net/viewvc/octave/trunk/octave- >> forge/main/image/inst/mat2gray.m >> ) to your file and resubmit it please. >> >> We'd prefer if the function is matlab compatible but we will accept it if >> it's >> not. Still, do you think it could make the API compatible? I don't know much >> about this subject and the communication package has no current >> maintainer, so I have no idea how much work that would be. >> >> Carnë > > Carnë, > > I've attached convenc.m with the suggested license. Making it compatible > with MATLAB is going to take some more effort. It is something that I will > look into doing this summer.
I have just added it to the comm package. It will be part of the next release. I have also wrote the help text into texinfo and added a simple check for the correct number of arguments. See http://octave.svn.sourceforge.net/viewvc/octave/trunk/octave-forge/main/comm/inst/convenc.m?revision=10206&view=markup Something very useful and shouldn't be much work for you is some simple test blocks at the bottom. Basically some one lines of code with the expected output. This will make it easier to identify when a function stops working (maybe because octave changed the API of some functions that convenc uses). See the %! lines at the bottom of this file for examples ( http://octave.svn.sourceforge.net/viewvc/octave/trunk/octave-forge/main/image/inst/mat2gray.m ) > Do you have a checklist showing how complete the Octave communications > package is as compared to MATLAB's communication toolkit? I remember there used to some pages with a list of functions from each package but I can't find them now. I think they can be automatically generated by the generate_html package. However, I don't trust much that comparison because: 1) octave-forge have functions that do the same but under a different name and API; 2) they are most likely out of date; 3) it doesn't account for functions that are in octave-forge but matlab hasn't managed to implement yet. Carnë ------------------------------------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev
