On 11 November 2012 09:54, Rafael Laboissiere <raf...@laboissiere.net> wrote: > * Carnë Draug <carandraug+...@gmail.com> [2012-11-08 19:38]: > >> a new release of the image package is out, version 2.0.0, by Carnë >> Draug. > > Thanks for this new release, Carnë. I am in the process of preparing > the Debian package for it. > > I noticed three issues in this tarball: > > 1) Although the large majority of the files are correctly encoded in > UTF-8, there are still some of them in Latin1: > > $ file inst/* | grep ISO > inst/bwarea.m: ISO-8859 text > inst/bwperim.m: ISO-8859 text > inst/edge.m: ISO-8859 text > inst/fspecial.m: ISO-8859 text > inst/im2double.m: ISO-8859 text > inst/im2int16.m: ISO-8859 text > inst/im2single.m: ISO-8859 text > inst/im2uint16.m: ISO-8859 text > inst/im2uint8.m: ISO-8859 text > inst/imperspectivewarp.m: ISO-8859 text > inst/imremap.m: ISO-8859 text > inst/imresize.m: ISO-8859 text > inst/label2rgb.m: ISO-8859 text > > This only affects the names of authors in the copyright notices, but is a > nuisance for generating the debian/copyright file for the Debian package.
Fix with r11422. Can I further help with this by creating a proper COPYRIGHT file for the package? I already tried to follow the debian upstream guide http://wiki.debian.org/UpstreamGuide#Licenses that asks to list each file and its license. > 2) The function 'bwmorph' calls 'erode' and 'dilate', which are > deprecated by the package itself. It would be good to change the code > to use imerode and imdilate. Thanks. Fixed with r11420. > 3) The function fftconv2 gives a wrong result when called like this: > "fftconv2 (vector1, vector2, matrix)", although this usage is advertised > in the help string. For the Debian package, I am planning to apply the > patch attached below, which (i) removes the advertisement from the help > string, (ii) gives an error message when the function is called with the > said usage and (iii) drop the tests with the said usage. You forgot to attach the patch. I don't know what changed to make this usage stop working so I only left a note on the source code and should not appear on the help string (at least it doesn't on my system). Do not remove the tests, mark them with xtest instead. I think I have done that before but apparently forgot to commit. I'd give a warning instead of an error since the reason it fails may be due to changes in the other functions it uses and users with different versions may actually get the correct results. Please see r11421. Carnë ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov _______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev
