On 11 November 2012 23:20, Carnë Draug <carandraug+...@gmail.com> wrote: > On 11 November 2012 16:39, Rafael Laboissiere <raf...@laboissiere.net> wrote: >> * Carnė Draug <carandraug+...@gmail.com> [2012-11-11 13:34]: >>> I don't know what changed to make this usage stop working so I only left a >>> note on the source code and should not appear on the help string (at least >>> it doesn't on my system). Do not remove the tests, mark them with xtest >>> instead. I think I have done that before but apparently forgot to commit. >>> I'd give a warning instead of an error since the reason it fails may be due >>> to changes in the other functions it uses and users with different versions >>> may actually get the correct results. Please see r11421. >> >> Well, IMHO it is not a good idea to allow function to give results that are >> known to be wrong. I will see with the other members of the DOG (Debian >> Octave Group) how we should proceed while waiting for the fix from upstream. > > Do you know when they stopped working? Do the tests also failed back > on Octave 3.2.4 in Debian stable?
Apparently this has always been wrong. The reason why it tests didn't fail back in 3.2.4 was because conv2 was wrong and fftconv2 was replicating that wrongness. Now that conv2 has been fixed, the test that compares it with conv2 fails. Basically this has never worked and an error is indeed more appropriate here. Thank you, Carnë ------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov _______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev
