On Sun, Nov 27, 2011 at 9:20 PM, Devin Han <[email protected]> wrote: > Hi all, > > I will terminate this discussion 24 hours later. Is there anything more > feedback for RC1? >
I think I found another issue. Remember the discussion we had about what went in NOTICE and what went in LICENSE file? I said LICENSE should only contain the Apache license and everything else should go in NOTICE. But I just read this JIRA issue from legal-discuss: https://issues.apache.org/jira/browse/LEGAL-62 I think I was wrong before. The full licenses for the code we ship should go into LICENSE. So Apache as well as other licenses. NOTICE then has any "required third-party notices" and "copyright notices moved from source files submitted to the ASF". The JIRA issue points to the Apache server as a good example: http://svn.apache.org/repos/asf/httpd/httpd/trunk/LICENSE -Rob > All of the reasonable suggestions will be included in RC2 and we will start > a formal vote for it in this week. > > 2011/11/25 Devin Han <[email protected]> > >> Thank you for point it out, will update in RC2. >> >> >> 2011/11/23 Svante Schubert <[email protected]> >> >>> Hi Devin, >>> >>> the RC1 looks good to me. >>> >>> Two minor remarks: >>> 1) if you use Maven 3, there is warning that in the pom.xml of the >>> Simple API the maven-assemply-plugin in line 390 is duplicated. >>> I removed the following >>> >>> <plugin> >>> <artifactId>maven-assembly-plugin</artifactId> >>> <executions> >>> <execution> >>> <id>single</id> >>> <phase>package</phase> >>> <goals> >>> <goal>single</goal> >>> </goals> >>> </execution> >>> </executions> >>> </plugin> >>> >>> and made a "mvn clean install" and the created artifacts are the same, >>> but the warning was gone. >>> >>> 2) And minor typo result to a JavaDoc warning in >>> trunk/generator/schema2template/src/main/javadoc/overview.html >>> >>> where the '@' of '@odf.attribute' have to be masked. >>> Line 245 will be changed from >>> * see {@odf.attribute ${attribute}} >>> to >>> * see {@odf.attribute ${attribute}} >>> >>> Looking forward to the RC1, >>> Svante >>> >>> Am 22.11.2011 03:27, schrieb Devin Han: >>> > Hi all, >>> > >>> > After learning Apache release policy[1], I prepared a candidate release >>> on >>> > people.apache.org. >>> > First time do this work, so maybe exist omission or misunderstand, >>> please >>> > examine it and give your comments. >>> > If this candidate is passed, is the technical work for the first release >>> > ready? >>> > >>> > The candidate for the ODF Toolkit 0.5-incubating-rc1 release is >>> available >>> > at: >>> > >>> > >>> http://people.apache.org/~devinhan/odftoolkit-release/odftoolkit-0.5-incubating/rc1 >>> > >>> > SVN Tag: >>> > >>> https://svn.apache.org/repos/asf/incubator/odf/tags/0.5-incubating-rc1/ >>> > >>> > Change Notes: >>> > >>> > >>> https://svn.apache.org/repos/asf/incubator/odf/tags/0.5-incubating-rc1/CHANGES.txt >>> > >>> > --------------------------------- >>> > [1]http://incubator.apache.org/guides/releasemanagement.html >>> > >>> > >>> > >>> >>> >> >> >> -- >> -Devin >> > > > > -- > -Devin >
