[
https://issues.apache.org/jira/browse/ODFTOOLKIT-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418168#comment-13418168
]
Svante Schubert commented on ODFTOOLKIT-50:
-------------------------------------------
Thanks for the update. The patches work fine. Now the OdfXMLHelper is moved.
The deletion did not work for me, but this might be some subversion problem, we
should not care atm.
For everyone else testing this, the latest document have to be added to the
test resources manually as well to let the GRDDLTest pass.
Three comments:
1) In the OdfXMLHelper you have added a new parameter for the transformation,
when you dump out the parameter to the console
Testsuite: org.odftoolkit.odfdom.pkg.GRDDLTest
sourceURL:
file:/C:/work/coding/odftoolkit-meta-20120718/odfdom/target/test-classes/test_rdfmeta.odtcontent.xml
sourceBaseURL:
file:/C:/work/coding/odftoolkit-meta-20120718/odfdom/target/test-classes/test_rdfmeta.odt/
DOCUMENT_URL:
file:///C:/work/coding/odftoolkit-meta-20120718/odfdom/target/test-classes/test_rdfmeta.odt/
Aside of the existing issue of the sourceURL that does not belong to your work
of the missing slash before the file name, is the single slash behind the
scheme wrong?
It is being received in OdfPacke Line 2160:
String baseURL = file.getCanonicalFile().toURI().toString();
The file URL have to look like:
file://host/path
With an empty host as in our case there should be three slashes. It is pretty
obvious in http://tools.ietf.org/html/rfc3986#page-16 and
http://tools.ietf.org/html/rfc4395#page-5
Long story short, it makes sense to fix it problem directly in the OdfPackage
instead adding a new semantically identical parameter
2) The Apache License header are missing for the new Java sources. Please add
them, otherwise the Apache RAT tool will let the build fail, once the sources
have been integrated.
3) I have seen your changes in the schema2template, but even when the source is
not generated all test pass. Can you expand the tests, that they fail if new
functionality is missing? In other word, we have to keep in eye on the test
coverage.
Keep up the good work!
Svante
> [gsoc2012] Add ODF 1.2 RDF metadata support to ODF Toolkit
> ----------------------------------------------------------
>
> Key: ODFTOOLKIT-50
> URL: https://issues.apache.org/jira/browse/ODFTOOLKIT-50
> Project: ODF Toolkit
> Issue Type: New Feature
> Components: generator
> Affects Versions: 0.7.5
> Environment: Operating System: All
> Platform: All
> Reporter: Svante Schubert
> Labels: gsoc, gsoc2012, mentor
> Fix For: 0.8.6
>
> Attachments: grddl_test_patch.txt, odfdom-metadata_20120718.patch,
> patch.txt, patch_20120618.txt, patch_20120710.txt, patch_20120711.txt,
> schema2templates-metadata_20120718.patch, test_rdfmeta.odt, test_rdfmeta.odt,
> test_rdfmeta.odt
>
>
> This is one of the greatest features for ODF 1.2 to allow the usage of RDF
> metadata on the document and the most important elements.
> As a co-editor of this spec, I got a special interest in making this feature
> come alive. In addition it has a positive side affect to the new OOo API,
> when scenarios are not even tested in the office, but as well from a
> different ODF library.
> Before creating a convenient API, the basic package feature has to be
> supported.
> Still I believe the usage of an RDF parser is still optional to keep ODFDOM
> small and give the user only what he really wants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
