[
https://issues.apache.org/jira/browse/ODFTOOLKIT-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430285#comment-13430285
]
Svante Schubert commented on ODFTOOLKIT-50:
-------------------------------------------
Hi Tao,
just some short feed-back, first of all I like the progress you are making!
Still in some kind of rush, therefore I was not able to look into the problems
myself and work out a solutions.
1) When I applied your patch, the ODFDOM test passed (in Netbeans, W7, JDK7).
When I rebuild the complete project, there are several ODFDOM tests not
working, as in LoadSaveTest the URL prefix file:/ and file:/// differ.
2) Just from a high level thoughts Object layout/naming.
a) I verified that even the Apache Incubator Jena project still uses the HP
Java Package names:
http://jena.apache.org/documentation/javadoc/jena/com/hp/hpl/jena/rdf/model/Model.html
b) The name JenaSink makes sense, as parameter are dependent to Jena. Do you
think it is easy to provide a mechanism (e.g. Factory) to allow users to use
different Metadata engines aside Jena?
c) Please double check if all classes are needed in a public interface or are
able to be taken from public view by moving to package level (removing
identifier), esp. the naming of "URIExtractor10" might be improved.
e) The org.odftoolkit.odfdom.rdfa package belongs into the
org.odftoolkit.odfdom.pkg.rdfa for all those parts specified in the lowest
package layer - see
http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part3.html
or it belongs into the org.odftoolkit.odfdom.dom.rdfa for all those parts
specified in the ODF XML specific layer - see
http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html
Do you believe you are able to split this?
Finally, to see your latest changes, I usually do a patch compare by cloning
the ODF Toolkit project twice to my hard disk and applying the latest and the
one before at each of them. After copying the files from the latest on the
other rep your latest changes become visible.
This gets annoying especially, I usually find time to review your work, when I
am travelling and SVN takes quite some traffic. Would you mind to provide the
patch to JIRA issue (legal and SVN users) and push your changes to some github?
If there is a problem, I am willing to push your latest work to github..
Thanks and keep up the good work!
Svante
> [gsoc2012] Add ODF 1.2 RDF metadata support to ODF Toolkit
> ----------------------------------------------------------
>
> Key: ODFTOOLKIT-50
> URL: https://issues.apache.org/jira/browse/ODFTOOLKIT-50
> Project: ODF Toolkit
> Issue Type: New Feature
> Components: generator
> Affects Versions: 0.7.5
> Environment: Operating System: All
> Platform: All
> Reporter: Svante Schubert
> Labels: gsoc, gsoc2012, mentor
> Fix For: 0.8.6
>
> Attachments: grddl_test_patch.txt, odfdom-metadata_20120718.patch,
> odfdom-metadata_20120722.patch, odfdom-metadata_20120725.patch,
> odfdom-metadata_20120729.patch, odfdom-metadata_20120802.patch,
> odfdom-metadata_20120806.patch, patch.txt, patch_20120618.txt,
> patch_20120710.txt, patch_20120711.txt,
> schema2templates-metadata_20120718.patch,
> schema2templates-metadata_20120806.patch, test_rdfmeta.odt, test_rdfmeta.odt,
> test_rdfmeta.odt, test_rdfmeta.odt, test_rdfmeta.odt, test_rdfmeta.odt
>
>
> This is one of the greatest features for ODF 1.2 to allow the usage of RDF
> metadata on the document and the most important elements.
> As a co-editor of this spec, I got a special interest in making this feature
> come alive. In addition it has a positive side affect to the new OOo API,
> when scenarios are not even tested in the office, but as well from a
> different ODF library.
> Before creating a convenient API, the basic package feature has to be
> supported.
> Still I believe the usage of an RDF parser is still optional to keep ODFDOM
> small and give the user only what he really wants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
