[
http://issues.apache.org/jira/browse/OFBIZ-523?page=comments#action_12455665 ]
Jacopo Cappellato commented on OFBIZ-523:
-----------------------------------------
Ray,
are you sure it works?
I've not tested your patch but the command:
Map itemsMap = UtilMisc.toMap("statusId", "ITEM_CREATED", "statusId",
"ITEM_APPROVED");
orderItems = orderHeader.getRelated("OrderItem", itemsMap, null);
is translated to the sql equivalent of:
... where statusId = 'ITEM_CREATED' and statusId = 'ITEM_APPROVED'
And so no record is selected.
Am I wrong?
> Small change that can greatly reduce the amount of processing that
> autoCancelOrderItems does...
> -----------------------------------------------------------------------------------------------
>
> Key: OFBIZ-523
> URL: http://issues.apache.org/jira/browse/OFBIZ-523
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Attachments: autocancelorderitems.patch
>
>
> This patch only changes two files:
> services.xml - I've just re-written the comment based on reading and
> understanding the code in the method. Hopefully people will find this clearer
> and more precise about how it functions in different ways for orders at the
> CREATED and APPROVED status.
> OrderServices.java - This is the real perfomance change, I've just inserted a
> Map filter so the sales order items code block will only check for cancel
> dates against line items that have a CREATED or APPROVED status. It only
> wastes time and resource to check COMPLETED, CANCELLED and REJECTED order
> items.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
