[ http://issues.apache.org/jira/browse/OFBIZ-523?page=all ]
Ray Barlow updated OFBIZ-523:
-----------------------------
Attachment: autocancelorderitems_v2.patch
Jacopo,
Thanks for the review and here is a replacement patch that addresses your
comments, strange it wasn't failing completely when testing but could be Derby.
It now uses a more selective findByAnd method which has the advantage of
reducing the SQL results even further prior to the final date tests.
I've been through and retested with an order that has approved and created line
items with several scenarios for the values of autoCancelDate, autoCancelDate
etc
Ray
> Small change that can greatly reduce the amount of processing that
> autoCancelOrderItems does...
> -----------------------------------------------------------------------------------------------
>
> Key: OFBIZ-523
> URL: http://issues.apache.org/jira/browse/OFBIZ-523
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Attachments: autocancelorderitems.patch, autocancelorderitems_v2.patch
>
>
> This patch only changes two files:
> services.xml - I've just re-written the comment based on reading and
> understanding the code in the method. Hopefully people will find this clearer
> and more precise about how it functions in different ways for orders at the
> CREATED and APPROVED status.
> OrderServices.java - This is the real perfomance change, I've just inserted a
> Map filter so the sales order items code block will only check for cancel
> dates against line items that have a CREATED or APPROVED status. It only
> wastes time and resource to check COMPLETED, CANCELLED and REJECTED order
> items.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
