[ 
http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12459214 ] 
            
Chris Howe commented on OFBIZ-456:
----------------------------------

The demo data is imported using the complete entity record 
(accounting/data/PaymentsInvoices.xml) which contains a 5 place padded 
invoiceItemSeqId.  That data gets entered without utilizing the service that 
gets called when an order changes status to "Completed" and an invoice is 
created.

Backward Compatibility: It's not a big issue, but does need to be considered 
before closing this issue.  Iain discovered this issue obviously because his 
report is listing invoiceItemSeqId 100 before it lists invoiceItemSeqId 2.  As 
I see it there are a few options:

1) change the method that is gathering the information for the report in 
question to convert the string to an integer
2) create a service that will update all fields of *.invoiceItemSeqId to the 
correct padding
3) ignore the issue

I would prefer Iain say that it doesn't need to be addressed.   It's not an 
encouragement for people to report bugs if they have the impression that they 
will need  to develop a personal solution anyway.   For someone that has 
invoices that have 100+ invoice line items I suspect he'll be finding extreme 
use case bugs more often than the rest of us.  Better for all of us that he 
feel encouraged to report them than have all of us get hit with the bugs when 
we reach that level of usage.

In any case, which fix would you prefer?
1) changing the individual lines in the java method
2) removing the padding  from the java method and letting the service handle it

1 is the quickest, but 2 allows for a centralized place

> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>         Assigned To: Si Chen
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, 
> etc). Not a problem until you have an invoice with more than 99 items, and 
> then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to