[ http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12459278 ] Jacopo Cappellato commented on OFBIZ-456: -----------------------------------------
I personally would opt for the first solution (changing the padding from 2 to 5 digits in individual lines in the java method). And yes, I can confirm that Chris is correct... newly created invoice items are created with two digits (still I'm wondering what kind of ugly tests I did some time ago :-( Backward compatibility: I think we could ignore the (minor) backward issue in this case (changing old order items could cause problems since they are in the pk and also there could be company that don't like this solution). If we can quickly add support for +100 items in invoices (as is here) I think we should go for the change... even if this is something that it will not happen in my deployment or the ones of my customers. Iain: about your last requirement (i.e. keeping the adjustments 'near' the invoice items to which they are applied) I'd say that, it would be better if you handle it in the report (maybe with custom code); in fact it should be easy to accomplish since the InvoiceItems of type 'adjustment' are associated to the parent InvoiceItem thru the PARENT_INVOICE_ID and PARENT_INVOICE_ITEM_SEQ_ID fields. > Invoice item sequence ids are ordered alphabetically, not numerically > --------------------------------------------------------------------- > > Key: OFBIZ-456 > URL: http://issues.apache.org/jira/browse/OFBIZ-456 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: accounting > Reporter: Iain Fogg > Assigned To: Si Chen > Priority: Minor > > Invoice item sequence numbers start with 2 significant "digits" (01, 02, > etc). Not a problem until you have an invoice with more than 99 items, and > then you find item 100 being displayed after item 10. > I expect the desired behaviour (and improvement) is obvious :-) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
