On Mon, 22 Mar 2010 23:45:14 -0700
Marcel Holtmann <[email protected]> wrote:

> please try to keep the code flow inside the functions as simple as
> possible. Otherwise things like this happen.

One suggestion I have for the future is to actually send your patches
to the mailing list for review, even if you've already committed them.
I can understand just committing things without public review for
expediency, but having many eyes looking at things can help as well.
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to