On Mon, 22 Mar 2010 23:45:14 -0700 Marcel Holtmann <[email protected]> wrote:
> And there was another problem with one variable being > guint16, but the is_option casts it back to guint8. We can't really have > that. Once you start casting on that scale the compiler will not warn > you about type mismatches or if the value of argument is too big for its > type. Can you please let me know which git commit this fix you made was? I want to review it because all of the option types should only be a byte anyway, so I am trying to figure out if there was a mistake somewhere where we were using is_option to examine a 16 bit value. I searched through the git log and can't figure out where this change was. I can see where you changed the option type we are comparing to a regular guint to avoid compiler problems, but not the other issue you mentioned. _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
