Hi Denis,
>-----Original Message----- >From: Denis Kenzior [mailto:[email protected]] >Sent: Wednesday, May 12, 2010 3:23 AM >To: [email protected] >Cc: Gu, Yang >Subject: Re: [PATCH 09/19] stkutil: Add poll interval proactive command parser > >Hi Yang, > >> union { >> + struct stk_duration duration; >> struct stk_command_display_text display_text; >> struct stk_command_get_inkey get_inkey; >> struct stk_command_get_input get_input; >> > >For symmetry / consistency with other commands, can we please make a struct >stk_command_poll_interval with only duration as a member? I agree with you to wrap duratioin in a struct. Personally, I'd also like to wrap all the fields of command details in stk_command into a struct, and fields of device identities into another struct. This will make stk_command_new_from_pdu() and unit tests more consistent and symmetric. Regards, -Yang _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
