Hi Yang,

> I agree with you to wrap duratioin in a struct. Personally, I'd also like
>  to wrap all the fields of command details in stk_command into a struct,
>  and fields of device identities into another struct. This will make
>  stk_command_new_from_pdu() and unit tests more consistent and symmetric.
> 

I'm actually fine with that.  Try seeing how it looks like.  If you think it 
looks better send a patch for review.

Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to