Hi Pasi, > From: Pasi Miettinen <[email protected]> > > --- > include/history.h | 2 + > src/sms.c | 157 > ++++++++++++++++++++++++++++++++++++++++++++++++++++- src/smsutil.h | > 6 ++ > 3 files changed, 163 insertions(+), 2 deletions(-) >
Some general comments: I'd like to see a status_report assembly similar to how the sms_assembly is done. This should exist in smsutil.c/.h so that we can easily unit test this functionality (which I would also like to see.) Another desirable feature for the status report assembly is to save off the status report fragments on disk, so that status reports (for multi-fragment SMSes) received across oFono / system reboots and crashes are handled appropriately. Regards, -Denis _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
