> Hi Pasi, > > > From: Pasi Miettinen <[email protected]> > > > > --- > > include/history.h | 2 + > > src/sms.c | 157 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++- src/smsutil.h > | > > 6 ++ > > 3 files changed, 163 insertions(+), 2 deletions(-) > > > > Some general comments: > > I'd like to see a status_report assembly similar to how the sms_assembly is > done. This should exist in smsutil.c/.h so that we can easily unit test this > functionality (which I would also like to see.) > > Another desirable feature for the status report assembly is to save off the > status report fragments on disk, so that status reports (for multi-fragment > SMSes) received across oFono / system reboots and crashes are handled > appropriately. > > Regards, > -Denis
Hi Denis, Could you clarify a bit what do you mean by "status_report assembly silmilar to how the sms_assembly is done"? Currently I have a belief that status-report, which relates to sent concatenated message, does not know anything about other status-reports which relate to the same concatenated message. I have to admit that I am not sure if this belief is correct. Is it? If the status-reports of the concatenated message know about each other, then I might have some kind of picture what you are looking for concidering the status_report assembly. Otherwise I am little bit lost what you are after if my current solution does not satisfy you at all. Br, -Pasi _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
