Hi Denis,


>-----Original Message-----
>From: Denis Kenzior [mailto:denk...@gmail.com]
>Sent: Monday, September 27, 2010 8:49 AM
>To: ofono@ofono.org
>Cc: Gu, Yang
>Subject: Re: [PATCH 2/5] stk: Support send ss response
>
>Hi Yang,
>
>On 09/21/2010 05:21 AM, Yang Gu wrote:
>> ---
>>  src/stkutil.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/stkutil.c b/src/stkutil.c
>> index cdd6b4e..d35094b 100644
>> --- a/src/stkutil.c
>> +++ b/src/stkutil.c
>> @@ -5449,6 +5449,8 @@ const unsigned char *stk_pdu_from_response(const
>struct stk_response *response,
>>                                      &response->select_item.item_id,
>>                                      NULL);
>>              break;
>> +    case STK_COMMAND_TYPE_SEND_SS:
>> +            break;
>
>This seems wrong, isn't the additional information field mandatory?

I couldn't understand this comment well. Additional information is a part of 
result dataobj, so it's already included. Is there something I should handle 
further? 


Regards,
-Yang
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Reply via email to